fixing moderator overview on reshares#30884
Closed
ArtificialOwl wants to merge 3 commits intomasterfrom
Closed
Conversation
Member
ArtificialOwl
commented
Jan 27, 2022
ArtificialOwl
commented
- fix a call to a deprecated method is returns a non managed exception
- it now uses CircleManager. Still needs to check its availability as there is no integration of circles within core. left a TODO note.
- This is the most efficient way to know if a user is a (inherited) member of a circle and his access level
ArtificialOwl
requested review from
a team,
CarlSchwan,
come-nc,
nickvergessen and
skjnldsv
and removed request for
a team,
juliusknorr,
nickvergessen and
skjnldsv
Member
Author
|
(sorry for the mess, experiencing edge network, and UI had glitches :]) |
ArtificialOwl
requested review from
a team and
PVince81
and removed request for
a team
ArtificialOwl
force-pushed
the
fix/noid/call-to-deprecated-circles-api
branch
2 times, most recently
from
16081c3 to
7b48969
Compare
Member
|
Psalm is not happy :) |
Member
To fix it, run: From that I could see, it's just that we have less warning now :) |
ArtificialOwl
force-pushed
the
fix/noid/call-to-deprecated-circles-api
branch
2 times, most recently
from
0ecd1f8 to
fa562f7
Compare
Member
Author
|
@CarlSchwan @skjnldsv new errors does not seems related ! |
Member
Author
|
@CarlSchwan @PVince81 @come-nc can I have some review on this one pleas ? the drone issue does not seems related to current code |
come-nc
reviewed
Feb 14, 2022
come-nc
reviewed
Feb 14, 2022
come-nc
reviewed
Feb 14, 2022
ArtificialOwl
force-pushed
the
fix/noid/call-to-deprecated-circles-api
branch
from
e6ac03b to
8c84f51
Compare
come-nc
approved these changes
Feb 15, 2022
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
I cannot vouch for the logic as I do not understand what this does exactly but code looks good now.
come-nc
reviewed
Feb 15, 2022
Member
Author
|
/backport to stable23 |
Member
Author
|
/backport to stable22 |
Member
|
please check the tests: |
ArtificialOwl
force-pushed
the
fix/noid/call-to-deprecated-circles-api
branch
2 times, most recently
from
791ddf8 to
76281fc
Compare
Member
Author
|
/rebase |
Signed-off-by: Maxence Lange <[email protected]>
Signed-off-by: Maxence Lange <[email protected]>
Signed-off-by: Maxence Lange <[email protected]>
nextcloud-command
force-pushed
the
fix/noid/call-to-deprecated-circles-api
branch
from
1a22165 to
460081b
Compare
Member
|
@ArtificialOwl please resolve the conflict. I'm guessing this is still relevant (also for backport) despite being from January ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.